diff options
| author | Tudor Brindus <[email protected]> | 2020-10-18 16:26:01 -0400 |
|---|---|---|
| committer | Simon Ser <[email protected]> | 2020-10-18 22:37:42 +0200 |
| commit | 8355884fbd4ea04203614172424b27c5b74018ab (patch) | |
| tree | c7decf05e32202d1230924a7ddb5af6dd903016c /sway/desktop/xdg_shell.c | |
| parent | 5bd6a5ce3ff3cb879463646d4f88745420335b23 (diff) | |
transaction: validate X transaction completions by geometry, not size
Xwayland views are aware of their coordinates, so validating transaction
completions should take into account the reported coordinates of the
view. Prior to this commit they didn't, and matching dimensions would
suffice to validate the transaction.
Also introduced `transaction_notify_view_ready_immediately` to support
the fix from d0f7e0f without jumping through hoops to figure out the
geometry of an `xdg_shell` view.
Diffstat (limited to 'sway/desktop/xdg_shell.c')
| -rw-r--r-- | sway/desktop/xdg_shell.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sway/desktop/xdg_shell.c b/sway/desktop/xdg_shell.c index 03f37241..4d133a12 100644 --- a/sway/desktop/xdg_shell.c +++ b/sway/desktop/xdg_shell.c @@ -302,8 +302,7 @@ static void handle_commit(struct wl_listener *listener, void *data) { memcpy(&view->geometry, &new_geo, sizeof(struct wlr_box)); desktop_damage_view(view); transaction_commit_dirty(); - transaction_notify_view_ready_by_size(view, - new_geo.width, new_geo.height); + transaction_notify_view_ready_immediately(view); } else { memcpy(&view->geometry, &new_geo, sizeof(struct wlr_box)); } |