summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Ser <[email protected]>2021-09-20 18:32:44 +0200
committerSimon Zeni <[email protected]>2021-09-22 10:45:39 -0600
commit7a4056aaa24353165ea2d6f082c541a2b370333a (patch)
tree112cb906885e92d54abbd4b928e2db952d351f5a
parent6c1a00b6d73e4374d1ec354366cade34d0f66e4d (diff)
scene: unify intersection logic in wlr_scene_node_at
Let's extract the common bits.
-rw-r--r--wlr_scene.c31
1 files changed, 13 insertions, 18 deletions
diff --git a/wlr_scene.c b/wlr_scene.c
index 31e0fd9..7f8f8e7 100644
--- a/wlr_scene.c
+++ b/wlr_scene.c
@@ -445,36 +445,31 @@ struct wlr_scene_node *wlr_scene_node_at(struct wlr_scene_node *node,
}
}
+ bool intersects = false;
switch (node->type) {
case WLR_SCENE_NODE_ROOT:
case WLR_SCENE_NODE_TREE:
break;
case WLR_SCENE_NODE_SURFACE:;
struct wlr_scene_surface *scene_surface = wlr_scene_surface_from_node(node);
- if (wlr_surface_point_accepts_input(scene_surface->surface, lx, ly)) {
- if (nx != NULL) {
- *nx = lx;
- }
- if (ny != NULL) {
- *ny = ly;
- }
- return &scene_surface->node;
- }
+ intersects = wlr_surface_point_accepts_input(scene_surface->surface, lx, ly);
break;
case WLR_SCENE_NODE_RECT:;
struct wlr_scene_rect *rect = scene_rect_from_node(node);
- if (lx >= 0 && lx < rect->width && ly >= 0 && ly < rect->height) {
- if (nx != NULL) {
- *nx = lx;
- }
- if (ny != NULL) {
- *ny = ly;
- }
- return &rect->node;
- }
+ intersects = lx >= 0 && lx < rect->width && ly >= 0 && ly < rect->height;
break;
}
+ if (intersects) {
+ if (nx != NULL) {
+ *nx = lx;
+ }
+ if (ny != NULL) {
+ *ny = ly;
+ }
+ return node;
+ }
+
return NULL;
}