diff options
| author | Aylur <[email protected]> | 2024-10-29 18:10:07 +0000 |
|---|---|---|
| committer | Aylur <[email protected]> | 2024-10-29 18:26:54 +0000 |
| commit | 479e85aca3dfc60f92f3d98ec82a5d58607e24db (patch) | |
| tree | e68aa39ff5def49312b64d92d064b942ee794bc6 /lib/notifd | |
| parent | 8705ab494f448c508c43c4272b501a3f3bdbac70 (diff) | |
fixup(notifd): make dismissed signal internal
its used only internally, the resolved signal is meant to be the public
api
Diffstat (limited to 'lib/notifd')
| -rw-r--r-- | lib/notifd/notification.vala | 12 | ||||
| -rw-r--r-- | lib/notifd/proxy.vala | 4 | ||||
| -rw-r--r-- | lib/notifd/signals.md | 2 |
3 files changed, 3 insertions, 15 deletions
diff --git a/lib/notifd/notification.vala b/lib/notifd/notification.vala index 527a352..29c6c56 100644 --- a/lib/notifd/notification.vala +++ b/lib/notifd/notification.vala @@ -158,12 +158,6 @@ public class AstalNotifd.Notification : Object { */ public signal void resolved(ClosedReason reason); - /** - * Emitted when the user dismisses this notification. - * - * @see dismiss - */ - public signal void dismissed(); /** * Emitted when an [[email protected]] of this notification is invoked. @@ -173,12 +167,10 @@ public class AstalNotifd.Notification : Object { public signal void invoked(string action_id); /** - * Dismiss this notification popup - * - * This method doesn't have any functionality on its own, but should be handled - * by frontend implementation to hide notification popups. + * Resolve this notification with [[email protected]_BY_USER]. */ public void dismiss() { dismissed(); } + internal signal void dismissed(); /** * Invoke an [[email protected]] of this notification. diff --git a/lib/notifd/proxy.vala b/lib/notifd/proxy.vala index bedb8b9..95e7105 100644 --- a/lib/notifd/proxy.vala +++ b/lib/notifd/proxy.vala @@ -32,10 +32,6 @@ internal class AstalNotifd.DaemonProxy : Object { set { proxy.dont_disturb = value; } } - public uint[] notification_ids() throws DBusError, IOError { - return proxy.notification_ids(); - } - public Notification get_notification(uint id) { return notifs.get(id); } diff --git a/lib/notifd/signals.md b/lib/notifd/signals.md index cdc6688..e13b92c 100644 --- a/lib/notifd/signals.md +++ b/lib/notifd/signals.md @@ -5,7 +5,7 @@ ignore this, I'm just dumb and can't follow where signals go or get emitted from ## Notification * resolved(reason) - by daemon/proxy -* dismissed() - by user with `.dismiss()` +* dismissed() - by user with `.dismiss()`, used to emit resolved from proxy/daemon * invoked(action) - by user with `.invoke()` ## Deamon |