1 files changed, 20 insertions, 32 deletions

diff --git a/swaynag/main.c b/swaynag/main.c
index 88007818..56e4950b 100644
--- a/swaynag/main.c
+++ b/swaynag/main.c
@@ -20,33 +20,20 @@ void sway_terminate(int code) {
 }
 
 int main(int argc, char **argv) {
-	int exit_code = EXIT_SUCCESS;
+	int status = EXIT_SUCCESS;
 
 	list_t *types = create_list();
 	swaynag_types_add_default(types);
 
-	memset(&swaynag, 0, sizeof(swaynag));
 	swaynag.buttons = create_list();
 	wl_list_init(&swaynag.outputs);
 	wl_list_init(&swaynag.seats);
 
-	struct swaynag_button *button_close =
-		calloc(sizeof(struct swaynag_button), 1);
-	button_close->text = strdup("X");
-	button_close->type = SWAYNAG_ACTION_DISMISS;
-	list_add(swaynag.buttons, button_close);
-
-	swaynag.details.button_details =
-		calloc(sizeof(struct swaynag_button), 1);
-	swaynag.details.button_details->text = strdup("Toggle details");
-	swaynag.details.button_details->type = SWAYNAG_ACTION_EXPAND;
-
 	char *config_path = NULL;
 	bool debug = false;
-	int launch_status = swaynag_parse_options(argc, argv, NULL, NULL, NULL,
+	status = swaynag_parse_options(argc, argv, NULL, NULL, NULL,
 			&config_path, &debug);
-	if (launch_status != 0)  {
-		exit_code = launch_status;
+	if (status != 0)  {
 		goto cleanup;
 	}
 	sway_log_init(debug ? SWAY_DEBUG : SWAY_ERROR, NULL);
@@ -56,29 +43,29 @@ int main(int argc, char **argv) {
 	}
 	if (config_path) {
 		sway_log(SWAY_DEBUG, "Loading config file: %s", config_path);
-		int config_status = swaynag_load_config(config_path, &swaynag, types);
-		free(config_path);
-		if (config_status != 0) {
-			exit_code = config_status;
+		status = swaynag_load_config(config_path, &swaynag, types);
+		if (status != 0) {
 			goto cleanup;
 		}
 	}
 
+	swaynag.details.button_details.text = strdup("Toggle details");
+	swaynag.details.button_details.type = SWAYNAG_ACTION_EXPAND;
+
 	if (argc > 1) {
 		struct swaynag_type *type_args = swaynag_type_new("<args>");
 		list_add(types, type_args);
 
-		int result = swaynag_parse_options(argc, argv, &swaynag, types,
+		status = swaynag_parse_options(argc, argv, &swaynag, types,
 				type_args, NULL, NULL);
-		if (result != 0) {
-			exit_code = result;
+		if (status != 0) {
 			goto cleanup;
 		}
 	}
 
 	if (!swaynag.message) {
 		sway_log(SWAY_ERROR, "No message passed. Please provide --message/-m");
-		exit_code = EXIT_FAILURE;
+		status = EXIT_FAILURE;
 		goto cleanup;
 	}
 
@@ -98,11 +85,13 @@ int main(int argc, char **argv) {
 
 	swaynag_types_free(types);
 
+	struct swaynag_button button_close = { 0 };
+	button_close.text = strdup("X");
+	button_close.type = SWAYNAG_ACTION_DISMISS;
+	list_add(swaynag.buttons, &button_close);
+
 	if (swaynag.details.message) {
-		list_add(swaynag.buttons, swaynag.details.button_details);
-	} else {
-		free(swaynag.details.button_details->text);
-		free(swaynag.details.button_details);
+		list_add(swaynag.buttons, &swaynag.details.button_details);
 	}
 
 	sway_log(SWAY_DEBUG, "Output: %s", swaynag.type->output);
@@ -120,12 +109,11 @@ int main(int argc, char **argv) {
 
 	swaynag_setup(&swaynag);
 	swaynag_run(&swaynag);
-	return exit_code;
+	return status;
 
 cleanup:
 	swaynag_types_free(types);
-	free(swaynag.details.button_details->text);
-	free(swaynag.details.button_details);
+	free(swaynag.details.button_details.text);
 	swaynag_destroy(&swaynag);
-	return exit_code;
+	return status;
 }