1 files changed, 47 insertions, 23 deletions

diff --git a/sway/input/cursor.c b/sway/input/cursor.c
index 7390816f..d608a9cf 100644
--- a/sway/input/cursor.c
+++ b/sway/input/cursor.c
@@ -50,21 +50,23 @@ static struct sway_container *container_at_cursor(struct sway_cursor *cursor,
 	struct wl_list *unmanaged = &root_container.sway_root->unmanaged_views;
 	struct sway_view *view;
 	wl_list_for_each_reverse(view, unmanaged, unmanaged_view_link) {
-		if (view->type == SWAY_XWAYLAND_VIEW) {
-			struct wlr_xwayland_surface *xsurface = view->wlr_xwayland_surface;
-			struct wlr_box box = {
-				.x = xsurface->x,
-				.y = xsurface->y,
-				.width = xsurface->width,
-				.height = xsurface->height,
-			};
-
-			if (wlr_box_contains_point(&box, cursor->x, cursor->y)) {
-				*surface = xsurface->surface;
-				*sx = cursor->x - box.x;
-				*sy = cursor->y - box.y;
-				return view->swayc;
-			}
+		if (view->type != SWAY_XWAYLAND_VIEW) {
+			continue;
+		}
+
+		struct wlr_xwayland_surface *xsurface = view->wlr_xwayland_surface;
+		struct wlr_box box = {
+			.x = xsurface->x,
+			.y = xsurface->y,
+			.width = xsurface->width,
+			.height = xsurface->height,
+		};
+
+		if (wlr_box_contains_point(&box, cursor->x, cursor->y)) {
+			*surface = xsurface->surface;
+			*sx = cursor->x - box.x;
+			*sy = cursor->y - box.y;
+			return NULL;
 		}
 	}
 
@@ -125,7 +127,10 @@ static void cursor_send_pointer_motion(struct sway_cursor *cursor,
 	struct wlr_seat *seat = cursor->seat->wlr_seat;
 	struct wlr_surface *surface = NULL;
 	double sx, sy;
-	container_at_cursor(cursor, &surface, &sx, &sy);
+	struct sway_container *c = container_at_cursor(cursor, &surface, &sx, &sy);
+	if (c && config->focus_follows_mouse) {
+		sway_seat_set_focus_warp(cursor->seat, c, false);
+	}
 
 	// reset cursor if switching between clients
 	struct wl_client *client = NULL;
@@ -156,8 +161,8 @@ static void handle_cursor_motion(struct wl_listener *listener, void *data) {
 	cursor_send_pointer_motion(cursor, event->time_msec);
 }
 
-static void handle_cursor_motion_absolute(struct wl_listener *listener,
-		void *data) {
+static void handle_cursor_motion_absolute(
+		struct wl_listener *listener, void *data) {
 	struct sway_cursor *cursor =
 		wl_container_of(listener, cursor, motion_absolute);
 	struct wlr_event_pointer_motion_absolute *event = data;
@@ -170,11 +175,30 @@ static void handle_cursor_button(struct wl_listener *listener, void *data) {
 	struct sway_cursor *cursor = wl_container_of(listener, cursor, button);
 	struct wlr_event_pointer_button *event = data;
 
-	if (event->button == BTN_LEFT) {
-		struct wlr_surface *surface = NULL;
-		double sx, sy;
-		struct sway_container *cont =
-			container_at_cursor(cursor, &surface, &sx, &sy);
+	struct wlr_surface *surface = NULL;
+	double sx, sy;
+	struct sway_container *cont =
+		container_at_cursor(cursor, &surface, &sx, &sy);
+	// Avoid moving keyboard focus from a surface that accepts it to one
+	// that does not unless the change would move us to a new workspace.
+	//
+	// This prevents, for example, losing focus when clicking on swaybar.
+	//
+	// TODO: Replace this condition with something like
+	// !surface_accepts_keyboard_input
+	if (surface && cont && cont->type != C_VIEW) {
+		struct sway_container *new_ws = cont;
+		if (new_ws && new_ws->type != C_WORKSPACE) {
+			new_ws = container_parent(new_ws, C_WORKSPACE);
+		}
+		struct sway_container *old_ws = sway_seat_get_focus(cursor->seat);
+		if (old_ws && old_ws->type != C_WORKSPACE) {
+			old_ws = container_parent(old_ws, C_WORKSPACE);
+		}
+		if (new_ws != old_ws) {
+			sway_seat_set_focus(cursor->seat, cont);
+		}
+	} else {
 		sway_seat_set_focus(cursor->seat, cont);
 	}